Cpu memory optimization #3845
Open
Cpu memory optimization #3845
+138
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
cehongwang
force-pushed
the
cpu-memory-optimization
branch
from
de93114 to
15cf7eb
Compare
cehongwang
force-pushed
the
cpu-memory-optimization
branch
from
15cf7eb to
66b40bd
Compare
narendasan
reviewed
Oct 6, 2025
| ) | ||
|
|
||
| interpreter_result = interpreter.run() | ||
| # Delete the frozen parameters from the module to release CPU memory |
There was a problem hiding this comment.
Can we gate this by the same env variable as the malloc_trim?
There was a problem hiding this comment.
Do you mean something like
export low_RAM_mode=1 python flux.py or build env variable?
|
|
||
| # Move the weights in the state_dict to CPU | ||
| if offload_module_to_cpu: | ||
| deallocate_module(gm, delete_module=False) |
|
|
||
| # Here we delete the frozen parameters from the graph module. Note this does not affect the submodules. We are going to delete the frozen parameters from the submodules in the convert_module function. | ||
| # This is done to release CPU memory. | ||
| for attr in dir(gm): |
There was a problem hiding this comment.
Lets make this opt in similar to malloc trim
There was a problem hiding this comment.
Shouldn't this be cleared no matter what?
cehongwang
force-pushed
the
cpu-memory-optimization
branch
from
ad26f2c to
92775f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: